dtolnay / dtolnay/dissimilar

Missing parts from the original algorithm

Open
#7 0 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
241
Forks
18
PR merge metrics
No merged PRs in 30d

Description

Hi !

I noticed that several optimization that are present in the original implementations of the diff algorithm in this repo were not implemented in this crate. For instance dissimilar has no:

  • line_mode
  • half_diff
  • timeout
    (There may be other missing features that I did not notice)

Since there is no mention of it in the Readme, I was wondering why you did not include them.
Are these features you didn't have time to implement / don't think are useful or is there any issue preventing their implementation?
And as a result, do you think we should consider adding them to the crate?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare the crate's diff algorithm with the original implementations in Google's diff-match-patch repository. Start by investigating the mentioned line_mode, half_diff, and timeout optimizations, then check the README for documented scope. Done would require a decided, documented set of features and an agreed implementation plan.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
devtools
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.