dthree / dthree/vorpal

[2.0 Proposition] Rename vorpal.catch to avoid Promise ambiguity

Open
#325 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
JavaScript
Stars
5.6k
Forks
278
PR merge metrics
No merged PRs in 30d

Description

I think we should take benefit of the [inbuilding v2](https://github.com/dthree/vorpal/pull/272) to rename the `.catch()` commands.
One of the reason is that is connote a promise method, error handling of other command.
Besides it's usage is wrongly flagged as error by the [common used promised eslint config](https://github.com/xjamundx/eslint-plugin-promise) with rule `promise/catch-or-return`

I'm not sure on which name we should use, but something around `miss` like `onCommandMiss`, or `onNonMatchingCommand`, or maybe better and simpler`fallback`

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.