dthree / dthree/vorpal

Are tests not written correctly?

Open
#150 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
5.6k
Forks
278
PR merge metrics
No merged PRs in 30d

Description

In trying to update the solution for #52, I ran across my updates not passing the tests. First up, the [test](https://github.com/dthree/vorpal/blob/master/test/vorpal.js#L75) says that its missing the required option --required. I'm not sure if I actually broke something, or if the test just wasn't written properly. It appears that while the fixture doesn't pass any options, the [command](https://github.com/dthree/vorpal/blob/master/test/vorpal.js#L36) actually wants the `--required` option, it just wasn't provided.

Thoughts? Is this test written correctly?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.