dthree / dthree/cash

cash-global doesn't work in non-English operating systems

Open
#74 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
7.7k
Forks
198
PR merge metrics
No merged PRs in 30d

Description

Installing `cash-global` won't work properly in any OS whose language isn't English. That seems to be because of the test for the "Could not find" output of the `where` command in the `bin/preinstall.js` returning false positives in other languages.
I couldn't find it in the original source code though but I certainly don't actually have a grasp of the projects bigger structure.

For example the failing output of `where` in my German Windows looks like this

> INFORMATION: Es konnten keine Dateien mit dem angegebenen Muster gefunden werden.

I'd suggest using the npm `which` package instead since it's going to be included in the application anyways according to #71.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.