dssg / dssg/tyra

Remove duplication from get_model_groups

Open
#55 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
4
Forks
1
PR merge metrics
No merged PRs in 30d

Description

This if block: https://github.com/dssg/tyra/blob/master/webapp/query.py#L72

shouldn't be so big. The only thing that changes is the model_comment part, right? We can refactor this out either by dynamically generating that SQL clause, or using SQL logic. (ie "AND ({model_comment} = 'all' or {model_comment} = tbl.model_comment)"

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.