dssg / dssg/triage

Triage experiments should use list-making utility for temporal config

Open
#352 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Jupyter Notebook
Stars
201
Forks
62
PR merge metrics
No merged PRs in 30d

Description

Timechop converts things it expects to be lists if they are not already. For example: `test_label_timespans: '1month'` to `['1month']`. Triage should do this when it reads in the temporal config or every time it uses the config components instead of only doing it in timechop. That way, the architect label generator will not fail when it splits `'1month'` into `['1', 'm', 'o', 'n', 't', 'h']`.

https://github.com/dssg/triage/blob/df6b427660b7b3a4ee549ccc42cfb7128ce214cd/src/triage/experiments/base.py#L418

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.