dssg / dssg/triage

Support new collate arithmetic functionality

Open
#258 0 comments 0 reactions 0 assignees View on GitHub
collate
Dominant language
Jupyter Notebook
Stars
201
Forks
62
PR merge metrics
No merged PRs in 30d

Description

Collate supports arithmetic on the computed aggregates to make new aggregates, as of https://github.com/dssg/collate/pull/63. Triage should support this too, especially since it comes up as a wanted feature every once in a while.

It's not just a new kwarg, it's implemented in collate by overloading the operators on the aggregators, so it's not entirely clear what the semantics in the feature config will be.

This issue originally referred to both arithmetic and subquery functionality, but #250 refers to the subquery functionality, so I repurposed this.

Contributor guide

Open the contributing guide

Research direction

Start by reading the existing Triage feature configuration and the Collate arithmetic implementation referenced in pull request #63. Determine how overloaded aggregate operators should be represented in feature configuration, then define and validate the intended arithmetic semantics for Triage; the work is done when supported expressions are specified and covered by the project’s existing validation or test process.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.