dssg / dssg/triage

Move tracking valid imputations to collate

Open
#254 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Jupyter Notebook
Stars
201
Forks
62
PR merge metrics
No merged PRs in 30d

Description

_From @shaycrk on October 2, 2017 19:26_

Make the collate imputation objects keep track of their parameters and types of columns they can operate on so `FeatureGenerator._validate_imputation_rule()` doesn't need to be explicitly updated with every change to the supported imputation types.

_Copied from original issue: dssg/architect#47_

Contributor guide

Open the contributing guide

Research direction

Start by locating FeatureGenerator._validate_imputation_rule() and the collate imputation objects, then trace how supported imputation types and column parameters are currently represented. The refactor is done when validation derives this information from the collate objects and no longer needs explicit updates for each supported type.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
machine-learning
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.