dsccommunity / dsccommunity/SqlServerDsc
SqlWindowsFirewall: SourceCredential for SourcePath not used
Nobody has claimed this yet.
- Dominant language
- PowerShell
- Stars
- 385
- Forks
- 224
- PR merge metrics
- No merged PRs in 30d
Description
xSQLServerFirewall doesn't pass SourceCredential when it calls Get-TargetResource, so it can't access the setup executable:
Also, at a quick glance it seems like the only purpose for SourcePath is to check the SQL Server version. Would this be better done through the Registry?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in DSCResources/MSFT_xSQLServerFirewall/MSFT_xSQLServerFirewall.psm1 at the calls around lines 384 and 606, and trace how Get-TargetResource receives its parameters. Verify how SourceCredential should be passed when SourcePath points to the setup executable, then assess the issue’s question about checking the SQL Server version through the Registry. Done means the resource can access the executable with the supplied credential and the version-check behavior is covered by the agreed approach.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- powershell
- Domain
- infrastructure
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100