dsccommunity / dsccommunity/SqlServerDsc

SqlWindowsFirewall: Supporting path to executable for Analysis Services, but not used

Open
#328 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement help wanted
Dominant language
PowerShell
Stars
385
Forks
224
PR merge metrics
No merged PRs in 30d

Description

Details of the scenario you try and problem that is occurring:
The helper function Get-FirewallRule has the ability to get the executable for Analysis Services so it can be provided to a firewall rule. But no such rule is created.
So either it is not best practice to add the executable to the firewall rules, in that case the logic should be removed.
If it should be added to a firewall rule, then that logic need to be added.

The DSC configuration that is using the resource (as detailed as possible):
n/a

Version of the Operating System, SQL Server and PowerShell the DSC Target Node is running:
n/a

Version of the DSC module you're using, or 'dev' if you're using current dev branch:
Dev

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Get-FirewallRule helper and the code path that creates firewall rules for Analysis Services. Determine whether the executable path should be part of the rule, then make the implementation consistent with that decision; done means the unused logic is removed or the executable is applied, with the existing resource behavior verified.

Written by the indexing model from the issue text.

Assessment

Tech stack
powershell
Domain
devops, security
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.