dsccommunity / dsccommunity/SqlServerDsc

SQLRs: Potential breaking change for InstanceName

Open
#1,353 13 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement help wanted
Dominant language
PowerShell
Stars
385
Forks
224
PR merge metrics
No merged PRs in 30d

Description

Currently SQLRs has a parameter called 'InstanceName'. This is super confusing since Reporting Services useds instance name as well to specific SSRS or PBIRS. There is also a duplicate parameter called DatabaseInstance which makes it even more confusing.

I feel like DatabaseServer should include both the database server name and database instance, but this can be worked around for now.

I suggest taking back InstanceName and using it for RS. built-in https://docs.microsoft.com/en-us/sql/reporting-services/wmi-provider-library-reference/configurationsetting-property-instancename?view=sql-server-2017

The instance name is also located here: 'HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Microsoft SQL Server\Instance Names\RS'

I'm not sure if there is anyway to specify an InstanceName besides PBIRS or SSRS, but this should still be the key just in case there is way to do so.

The other issue is, if you have InstanceName as the database, but have SSRS and PowerBI installed on the same server, this could potentially be an issue.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the PowerShell DSC resources that define the SQLRs parameters, then compare the current InstanceName and DatabaseInstance handling with the Reporting Services documentation and the registry path mentioned in the issue. Done means the parameter roles are unambiguous for SSRS and PBIRS, with the breaking-change impact and database-instance behavior explicitly addressed.

Written by the indexing model from the issue text.

Assessment

Tech stack
powershell
Domain
databases, devops
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.