dsccommunity / dsccommunity/SqlServerDsc
SqlSetup: When Test-TargetResource does not find any features it should says so more clearly
Nobody has claimed this yet.
- Dominant language
- PowerShell
- Stars
- 385
- Forks
- 224
- PR merge metrics
- No merged PRs in 30d
Description
Details of the scenario you tried and the problem that is occurring:
When Test-TargetResource does not find any features it just outputs 'Features found:'. Maybe we should output 'Features found: None' so it's more clear that no features was found.
The DSC configuration that is using the resource (as detailed as possible):
SqlSetup 'InstallNamedInstance-INST2016'
{
InstanceName = 'INST2014'
Features = 'SQL'
SQLCollation = 'SQL_Latin1_General_CP1_CI_AS'
SourcePath = 'c:\temp\Sxs\SQL2014'
UpdateEnabled = 'False'
ForceReboot = $false
BrowserSvcStartupType = 'Automatic'
PsDscRunAsCredential = $SqlInstallCredential
}
Version of the Operating System, SQL Server and PowerShell the DSC Target Node is running:
n/a
What module (SqlServer or SQLPS) and which version of the module the DSC Target Node is running:
n/a
Version of the DSC module you're using, or 'dev' if you're using current dev branch:
Dev
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the SqlSetup Test-TargetResource code that produces the "Features found:" output. Update the empty-result wording to make clear that no features were found, then verify the resulting message through the relevant resource test or command output.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- powershell, sql
- Domain
- databases, devops
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100