dsccommunity / dsccommunity/SharePointDsc

SPInstallPrereqs: No windows features installed on Server 2025

Open Beginner friendly
#1,484 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C#
Stars
246
Forks
106
PR merge metrics
No merged PRs in 30d

Description

Problem description

There is a bug in the code where OS server level is selected. This results in no Windows features beeing installed on Windows Server 2025 if you install SPSE.

The bug is in the line below. There should be no dollar sign after Select-Object:

$OSServerLevel = Get-ComputerInfo | Select-Object $OSServerLevel

Verbose logs
[[SPInstallPrereqs]InstallPrereqs] Checking status now
[[SPInstallPrereqs]InstallPrereqs] File not blocked, continuing.
[[SPInstallPrereqs]InstallPrereqs] Version: SharePoint Server Subscription Edition
[[SPInstallPrereqs]InstallPrereqs] Getting installed windows features
[[SPInstallPrereqs]InstallPrereqs] Checking windows packages from the registry
DSC configuration
SPInstallPrereqs InstallPrereqs
        {
            IsSingleInstance     = "Yes"
            InstallerPath        = "..."
            OnlineMode           = $false
            SXSpath              = "..."
            DotNet48             = "..."
            MSVCRT142            = "..."
            PsDscRunAsCredential = $SPSetupAccount
        }
Suggested solution

Remove dollar sign so code looks like this:

$OSServerLevel = Get-ComputerInfo | Select-Object OSServerLevel

SharePoint version and build
SPSE 16.0.19725.20210
Operating system the target node is running
OsName               : Microsoft Windows Server 2025 Standard
OsOperatingSystemSKU : StandardServerEdition
OsArchitecture       : 64-bit
WindowsVersion       : 2009
WindowsBuildLabEx    : 26100.1.amd64fre.ge_release.240331-1435
OsLanguage           : en-US
OsMuiLanguages       : {en-US}
PowerShell version and build the target node is running
PSVersion                      5.1.20348.5499                                                                                                                                                                                                                                                                       
PSEdition                      Desktop                                                                                                                                                                                                                                                                              
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}                                                                                                                                                                                                                                                              
BuildVersion                   10.0.20348.5499                                                                                                                                                                                                                                                                      
CLRVersion                     4.0.30319.42000                                                                                                                                                                                                                                                                      
WSManStackVersion              3.0                                                                                                                                                                                                                                                                                  
PSRemotingProtocolVersion      2.3                                                                                                                                                                                                                                                                                  
SerializationVersion           1.1.0.1
SharePointDsc version
SharePointDSC 5.7.1   C:\Program Files\WindowsPowerShell\Modules\SharePointDSC\5.7.1\SharePointDSC.psd1

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the SPInstallPrereqs InstallPrereqs entry point and inspect the Get-ComputerInfo pipeline that assigns OSServerLevel. Verify the selected property on Windows Server 2025, then validate that the prerequisite installation detects and installs the required Windows features. Use any existing InstallPrereqs tests or validation available in the repository.

Written by the indexing model from the issue text.

Assessment

Tech stack
powershell
Domain
devops
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
78/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.