dsccommunity / dsccommunity/SChannelDsc
Replace commented-out assertions in DSC_SChannelSettings unit tests with skipped tests
@dan-hughes is already working on this.
Since Jan 28, 2026.
- Dominant language
- PowerShell
- Stars
- 13
- Forks
- 8
- PR merge metrics
- No merged PRs in 30d
Description
Description
The unit test file tests/Unit/DSC_SChannelSettings.Tests.ps1 contains multiple commented-out assertions for WinHttpDefaultSecureProtocols validation at lines 207-210, 368-371, and 529-532. These assertions are commented out due to 32-bit/64-bit system mismatches that cause test failures.
Current State
Commented-out assertions violate the coding guideline: "No commented-out code". The assertions are currently hidden and not tracked by test tooling.
Expected Outcome
Convert the commented-out assertions into properly skipped tests using Pester's -Skip parameter or Set-ItResult -Skipped, with clear skip reasons referencing the 32-bit/64-bit compatibility issue.
Context
- Reported by: @dan-hughes
- Pull Request: https://github.com/dsccommunity/SChannelDsc/pull/66
- Review Comment: https://github.com/dsccommunity/SChannelDsc/pull/66#discussion_r2737360154
Affected Locations
tests/Unit/DSC_SChannelSettings.Tests.ps1lines 207-210tests/Unit/DSC_SChannelSettings.Tests.ps1lines 368-371tests/Unit/DSC_SChannelSettings.Tests.ps1lines 529-532
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.