dsccommunity / dsccommunity/SChannelDsc

Replace commented-out assertions in DSC_SChannelSettings unit tests with skipped tests

Open
#67 0 comments 0 reactions 1 assignee View on GitHub

@dan-hughes is already working on this.

Since Jan 28, 2026.

Dominant language
PowerShell
Stars
13
Forks
8
PR merge metrics
No merged PRs in 30d

Description

Description

The unit test file tests/Unit/DSC_SChannelSettings.Tests.ps1 contains multiple commented-out assertions for WinHttpDefaultSecureProtocols validation at lines 207-210, 368-371, and 529-532. These assertions are commented out due to 32-bit/64-bit system mismatches that cause test failures.

Current State

Commented-out assertions violate the coding guideline: "No commented-out code". The assertions are currently hidden and not tracked by test tooling.

Expected Outcome

Convert the commented-out assertions into properly skipped tests using Pester's -Skip parameter or Set-ItResult -Skipped, with clear skip reasons referencing the 32-bit/64-bit compatibility issue.

Context

Affected Locations

  • tests/Unit/DSC_SChannelSettings.Tests.ps1 lines 207-210
  • tests/Unit/DSC_SChannelSettings.Tests.ps1 lines 368-371
  • tests/Unit/DSC_SChannelSettings.Tests.ps1 lines 529-532

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.