dsccommunity / dsccommunity/NetworkingDsc

Improve Unit Test Assertions for WinsServerAddress and Common Functions

Open
#409 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
PowerShell
Stars
235
Forks
93
PR merge metrics
No merged PRs in 30d

Description

The unit tests for the WInsServerAddress resource do not make assertions on the parameters being passed to the Mocks. There is also a gap in coverage over the Assert-ResourceProperty function.

The Common functions Get-WinsClientServerStaticAddress and Set-WinsClientServerStaticAddress also require improvements over the assertions on parameters being passed.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the unit tests for the WinsServerAddress resource and the Common functions Get-WinsClientServerStaticAddress and Set-WinsClientServerStaticAddress. Review the existing mock calls and the Assert-ResourceProperty coverage, then run the relevant PowerShell unit-test suite. Done means the tests assert the passed parameters and cover Assert-ResourceProperty as described.

Written by the indexing model from the issue text.

Assessment

Tech stack
powershell
Domain
testing-qa
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.