ds300 / ds300/patch-package

patch-package should ignore files defined in yarnclean file

Open
#564 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
11.2k
Forks
325
PR merge metrics
No merged PRs in 30d

Description

I'm running into an error running patch-package on a specific package. I noticed that the patch file removes a `README.md` file. This is due to my `.yarnclean` file defining `*.md` files for removal. So, I believe `yarn install` is running - removing the markdown file, then patch-package is running and becoming confused with the removal of the md file somehow?

Removing the `*.md` line from my `.yarnclean` file caused the patch to be successful: https://github.com/cypress-io/cypress/pull/31449/commits/38469fd1984d7edce8c9f6c7cb5236a4f10a17e8

I think `.yarnclean` is not playing well with `patch-package. Maybe this should be updated to ignore files similar to how `.gitignore` directories are ignored? https://github.com/ds300/patch-package/blob/bd2e9a49d884516199079add143c1649541e8efe/src/makePatch.ts#L265

**Error**

CI error: https://app.circleci.com/pipelines/github/cypress-io/cypress/69268/workflows/ac2b9f29-e0fd-4d4c-b837-a4bc75b0a860/jobs/2847547

```
**ERROR** Failed to apply patch for package snap-shot-core at path

node_modules/snap-shot-core

This error was caused because patch-package cannot apply the following patch file:

patches/snap-shot-core+10.2.4.dev.patch

Try removing node_modules and trying again. If that doesn't work, maybe there was
an accidental change made to the patch file? Try recreating it by manually
editing the appropriate files and running:

patch-package snap-shot-core

If that doesn't work, then it's a bug in patch-package, so please submit a bug
report. Thanks!

https://github.com/ds300/patch-package/issues

---
patch-package finished with 1 error(s).
node:child_process:966
throw err;
^

Error: Command failed: patch-package && lerna run rebuild-better-sqlite3 --scope @packages/server
```

You can see how the PR diff including removing the Readme file: https://github.com/cypress-io/cypress/pull/31449/files#diff-6d4ec7fb70a72c8193e10a8c390b904e6313087e19b3d2a191d466cc31063441

This seemed to work on other patches I made though - [like here](https://github.com/cypress-io/cypress/pull/31416/files#diff-6f0aeefc6eed294f2c4732238510deb6ef6ba69a3a1e3723bdd2c2602493f292) - so I'm not sure why this one failed.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.