ds300 / ds300/patch-package

Not sure if I'm clear on how to re-apply updated patch...

Open
#520 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
11.2k
Forks
325
PR merge metrics
No merged PRs in 30d

Description

This is a great tool. I really like it. Thank you!

My issue is that I'm not seeing the updated patch without deleting node_modules.

I'm likely a bit confused about what to expect when I apply the patches. I'm in a React dev environment, so using node to serve the app. I have updated patches and can confirm visually that the changes are in the patches directory as expected. However, despite a forced reload of my browser, the updated patch does not show up.

Here is my workflow:

1. update the source file in node_modules
2. rebuild the patch with `yarn patches/package-name`
3. visually confirm the updates by `cat patches/package-name.patch`
4. apply the patch to my project ` ./node_modules/.bin/patch-package`
5. yarn start

I can also just run `yarn install` in step 4 because I have the `"postinstall": "patch-package"` entry in my package.json file.

Either way, I don't see the updated patch in the code loaded into the browser (despite a hard reload).

What works is deleting node_modules and running a fresh install. That workflow is troublesome, but hopefully, I can avoid it while debugging the patch.

Thank you in advance for any pointers!

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.