ds300 / ds300/patch-package

NPM Module including `@` fails to patch on Windows.

Open
#286 2 comments 5 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
11.2k
Forks
325
PR merge metrics
No merged PRs in 30d

Description

Hi guys.

I made a patch for one of the `@types` NPM modules - (`@types/react-native` to be specific), but it failed with the following message.
```cmd
> yarn patch @types/react-native
yarn run v1.22.10
$ npx patch-package @types/react-native
patch-package 6.2.2
No such package @types\react-native

File not found: C:/Users/madst/Workspace/organiced/app/node_modules/package.json
npm ERR! code 1
npm ERR! path C:\Users\madst\Workspace\organiced\app
npm ERR! command failed
npm ERR! command C:\Windows\system32\cmd.exe /d /s /c patch-package @types\react-native

npm ERR! A complete log of this run can be found in:
npm ERR! C:\Users\madst\AppData\Local\npm-cache\_logs\2021-01-24T19_44_52_420Z-debug.log
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
```

I've successfully patched other module on Windows Powershell without any issues, but I assume it's because this package includes an `@`.

Instead I used WSL to patch the package through Linux and it went successfully.

Funny :)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.