drupal-graphql / drupal-graphql/graphql

[4.x] Remove caching clause in FromParent resolver

Open
#1,274 1 comment 0 reactions 0 assignees View on GitHub
4.x performance
Dominant language
PHP
Stars
287
Forks
198
PR merge metrics
No merged PRs in 30d

Description

I think we can remove the explicit adding of the value to our cacheability information in https://github.com/drupal-graphql/graphql/blob/fa9764fb93284481cc4f3de1124e0a1f4c987176/src/GraphQL/Resolver/ParentValue.php#L19-L21

Since we already do so for all the results in our field resolver https://github.com/drupal-graphql/graphql/blob/fa9764fb93284481cc4f3de1124e0a1f4c987176/src/Entity/Server.php#L354-L358

This may seem like a small optimisation, but when looking at a relatively complex query `addCacheableDependency` was actually a place where the most time was spent and I the`FromParent` producer is actually on a hot path because a lot of fields use the parent's value to refine it further, so removing this unneeded function call may make a difference.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.