drupal-graphql / drupal-graphql/graphql

Config schema definition of graphql server and exported config doesn't match

Open
#1,177 1 comment 0 reactions 0 assignees View on GitHub
4.x bug
Dominant language
PHP
Stars
287
Forks
198
PR merge metrics
No merged PRs in 30d

Description

We have an exported config that looks like this:

```
langcode: en
status: true
dependencies: { }
name: thunder_graphql
label: 'Thunder - GraphQL Server'
schema: composable
schema_configuration:
composable:
extensions:
thunder_paragraphs: thunder_paragraphs
thunder_media: thunder_media
thunder_routing: thunder_routing
thunder_pages: thunder_pages
persisted_queries_settings: { }
endpoint: /graphql
debug_flag: 0
caching: true
batching: true
```

There are two problems with this config:

1. The `schema_configuration` doesn't match the schema definition

```
schema_configuration:
type: 'graphql.schema.[%parent.schema]'
```
The schema definition needs to be this to match::
```
schema_configuration:
type: mapping
label: 'Schema config'
mapping:
composable:
label: Composable schema
type: graphql.schema.composable
```
Or the exported config structure has to change.

2. The sequence in `graphql.schema.composable` is defined as boolean but it's exported as strings
```
schema_configuration:
composable:
extensions:
thunder_paragraphs: thunder_paragraphs
thunder_media: thunder_media
thunder_routing: thunder_routing
thunder_pages: thunder_pages
```

I think that should be changed to
```
schema_configuration:
composable:
extensions:
thunder_paragraphs: true
thunder_media: true
thunder_routing: true
thunder_pages: true
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.