dropbox / dropbox/zxcvbn

Suggestion should be shown when password matches user input

Open
#129 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
CoffeeScript
Stars
16.1k
Forks
1k
PR merge metrics
No merged PRs in 30d

Description

Right now, when the password matches a user input passed to `zxcvbn`, the score gets reduced to 0 but no relevant feedback is created. For example, if I make the password the same as the email address:

screen shot 2016-01-27 at 11 47 24 am

This feedback is not relevant to this situation. It would be much better to have a suggestion generated such as "Don't use personal information such as your name or email address in your password."

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at the zxcvbn entry point that accepts user inputs and trace how a password matching one of them is scored and assigned feedback. Reproduce the email-address example, then verify that the result includes a suggestion about avoiding personal information rather than only the current irrelevant feedback.

Written by the indexing model from the issue text.

Assessment

Tech stack
coffeescript
Domain
security
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.