dropbox / dropbox/rust-brotli

Unnecessary loop

Open
#75 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
943
Forks
109
Avg merge
8d 3h
Merged PRs (30d)
1

Description

https://github.com/dropbox/rust-brotli/blob/5d82b69d1aaee6e0fdac6a35654cf7cea40c1057/src/enc/backward_references/hq.rs#L920

This loop `continue30` is unnecessary because it will eventually break at line 1018. If we remove this loop and change all the `break 'continue30;` into `continue` and change all the `break 'break29;` into `break`, the execution time will decreased from 3.76s to 3.43s based on my test, which is a 1.1x speedup.

Hope this information helps!

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in src/enc/backward_references/hq.rs around line 920 and inspect the continue30 loop through the break near line 1018. Reproduce the reported execution-time comparison, then verify that the requested loop and label changes preserve behavior while achieving the reported performance improvement.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
performance
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.