dropbox / dropbox/rust-alloc-no-stdlib

Macros are not self-contained

Open
#19 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
180
Forks
21
PR merge metrics
No merged PRs in 30d

Description

Exported Rust macros (per best "hygiene" practices) should not require any external paths to be brought into local scope. So, if a crate exports a macro, that macro should only use fully-qualified items from the same crate, or more specifically - use the `$crate` metavariable per [docs](https://veykril.github.io/tlborm/decl-macros/minutiae/hygiene.html#crate).

At least `declare_stack_allocator_struct!` macro uses non-fully-qualified identifiers like `declare_stack_allocator_struct!` inside, requiring crate users to `use` it, making the code unclean and possibly error prone.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.