dropbox / dropbox/pynsot

Improve exception erroring

Open
#82 2 comments 0 reactions 0 assignees View on GitHub
documentation enhancement help wanted
Dominant language
Python
Stars
46
Forks
22
PR merge metrics
No merged PRs in 30d

Description

This is what an exception for an attribute not existing when creating network looks like:

```
pynsot.vendor.slumber.exceptions.HttpClientError: Client Error 400: https://nsot.example.com/api/sites/4/networks/
```

That tells me nothing. You can catch the exception and inspect `.response.json()`, but this should be part of our client lib. We should create our own exception types.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reviewing how vendor.slumber.exceptions.HttpClientError is caught in the client library and how response.json() is currently inspected. Define the exception types and the error information they should expose, then verify that an attribute-missing network request produces a useful client exception instead of only the generic HTTP error.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.