dropbox / dropbox/pyannotate

Some things we can learn from pytypes

Open
#38 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
1.4k
Forks
60
PR merge metrics
No merged PRs in 30d

Description

I checked the profiling hook in [pytypes](https://github.com/Stewori/pytypes/blob/master/pytypes/type_util.py#L1893), and they do two things we should also do:
- save and restore the previously active profiler
- in a thread, when the profiling callback is run after profiling has been stopped, reset the hook
(note: this should only be done after it's been stopped -- not after it's been paused)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.