dropbox / dropbox/pyannotate

API to reset all; API to wrap all

Open
#28 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Python
Stars
1.4k
Forks
60
PR merge metrics
No merged PRs in 30d

Description

The `init_types_collection()` function installs the tracing callbacks and sets the filename filter, but doesn't reset the globals containing collected data. Maybe it should also do that. Or maybe we need a separate API to do that. (Currently the pyannotate unit tests reset a whole bunch of globals at the start of each test -- this should become a single call.)

Second, `with collect_types.collect()` only calls `resume()` and `pause()` -- we could use another context manager that calls `init_types_collection()` and `dump_stats()` as well.

(Note that the non-context-manager APIs are also important, e.g. for use in test fixtures, where there are traditionally separate `setUp()` and `tearDown()` methods.)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.