dropbox / dropbox/pilot

SimpleSectionedModelCollection should ensure any .loaded event results in loaded state

Open
#163 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Swift
Stars
113
Forks
19
PR merge metrics
No merged PRs in 30d

Description

Basically https://github.com/dropbox/pilot/blob/master/Core/Source/MVVM/SimpleModelCollection.swift#L78 needs to add an empty section `[.loaded([])]` if there are no sections at all since flattenedState treats `[]` as `.notLoaded`

Which leads to the surprising interaction where a consumer sends an empty load that is interpreted as content never having loaded.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.