dropbox / dropbox/nsot

Refactor common model helpers/validators into a single place

Open
#318 0 comments 0 reactions 0 assignees View on GitHub
refactor
Dominant language
Python
Stars
407
Forks
61
PR merge metrics
No merged PRs in 30d

Description

Following #317 @narJH27 had this feedback:

>This looks great! Just one suggestion from my end, there are too many repetitions of clean_site(), clean_fields() and save() which I feel could easily be moved to a base class from where the specific model classes could subclass and overload the methods if needed. This is just to avoid duplication of the same block of code over and over again.

This is a great idea for the V2 API, to reduce duplication.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.