dropbox / dropbox/nsot

Bug in circuit create serializer: Doesn't include the "site" field.

Open
#303 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Python
Stars
407
Forks
61
PR merge metrics
No merged PRs in 30d

Description

This isn't caught because we have few use-cases that include top-level objects that aren't using site-specific API endpoints. We are not testing for this either.

e.g. `POST /api/circuits/` is hardly tested if at all, while `POST /api/sites/1/circuits/` is the bulk of our testing. I'm pretty certain that a test in the former case would fail with an error about missing `site` (`site_id`) since this value passed in implicitly in the latter example (more common).

So this isn't an active bug, but it's one I noted while working on the `Protocol` feature.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.