dropbox / dropbox/dropbox-sdk-js

support proxy settings

Open
#150 13 comments 1 reaction 1 assignee Claimed by @pran1990 View on GitHub
enhancement
Dominant language
JavaScript
Stars
970
Forks
353
Avg merge
9h 3m
Merged PRs (30d)
2

Description

Since you guys use superagent for your http requests, why not adding proxy support?

I have customers that allow outbound traffic only through their proxy. Which means, they cannot use Dropbox with my code at the moment.

Basically, just use superagent-proxy like this:

```js
var request = require('superagent');

require('superagent-proxy')(request);

downloadRequest = function (path, args, auth, host, accessToken, selectUser, proxy) {
. . .
apiRequest = request.post(getBaseURL(host) + path) . . .;

if (proxy) apiRequest.proxy(options.proxy);
. . .
```

The `proxy` parameter should be configured in the Dropbox constructor.

Thoughts?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.