dropbox / dropbox/dependency-guard

Create single task for tree configuration

Open
#77 2 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Kotlin
Stars
493
Forks
19
PR merge metrics
No merged PRs in 30d

Description

Now the separated `DependencyTreeDiffTask` instance is created for each guarded configuration.

But that is not necessary, because the dependencies `tree` rendering is done by `DependencyGraphsRenderer` in [`AsciiDependencyReportRenderer2`](https://github.com/dropbox/dependency-guard/blob/main/dependency-guard/src/main/kotlin/com/dropbox/gradle/plugins/dependencyguard/internal/tree/AsciiDependencyReportRenderer2.kt), that can be used with different configurations, depending on passed `ResolvedComponentResult`.

So rendering, comparing and baselining dependencies tree for all can be performed in one single task, like for the `list` configuration in `DependencyGuardListTask`.

Also, depending on the code complexity, handling `list` and `task` configurations may be done in the single task, since they have a lot of similar configs and logic.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.