dropbox / dropbox/dbx_build_tools

Go builds fail on filesystems that require UTF-8 filenames

Open
#37 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
209
Forks
34
PR merge metrics
No merged PRs in 30d

Description

I was trying out `dbx_build_tools` for our python project, but ran into an issue again that has been plaguing me for a while. The root cause is an upstream Bazel issue that I described in https://github.com/bazelbuild/bazel/issues/12986.

Basically Go's source tree has one file - a test case for its own support for UTF-8 filenames - that causes Bazel to blow up on filesystems that require filenames to be UTF-8 encoded. Such filesystems include whatever macOS uses these days, as well as ZFS with the `utf8only` flag set (which happens to be the default on Ubuntu when enabling ZFS support at installation time). I've attached a screenshot of the build failure resulting when I run `bazel build @dbx_build_tools//build_tools:bzl-gen`.

`rules_go` added a workaround in https://github.com/bazelbuild/rules_go/pull/2836. It shells out to the system `tar` command for `tar.gz` go archives.

![image](https://user-images.githubusercontent.com/124501/121244115-5c38d000-c853-11eb-878c-17e50cf1a4fe.png)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.