dropbox / dropbox/PyHive

Handle slashes in Presto schemas for SQLAlchemy URL

Open
#280 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
1.7k
Forks
545
PR merge metrics
No merged PRs in 30d

Description

When connecting a PrestoDB database to query a Apache Pulsar SQL worker, errors are occurring when working with a schema containing slashes.

The check from: https://github.com/dropbox/PyHive/blob/master/pyhive/sqlalchemy_presto.py#L106 is raising an exception whereas I expected the schema to contain the slash.

I believe the check should be removed or we need a way to escape the slashes:

- presto://localhost:8081/pulsar/public/default
- presto://localhost:8081/pulsar/public%2Fdefault

Example of integration can be found here: https://github.com/apache/incubator-superset/pull/7297

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.