drogonframework / drogonframework/drogon

`METHOD_ADD` and `ADD_METHOD_TO` do not consider unsigned types

Open
#2,059 1 comment 1 reaction 0 assignees View on GitHub
Dominant language
C++
Stars
14.3k
Forks
1.4k
Avg merge
1d 12h
Merged PRs (30d)
15

Description

**Describe the bug**
Creating an `HttpController` with methods that take in `uint64_t` for example, and making a request to -1 will underflow and become `UINT64_MAX`.
Another related bug is if the URL contains characters, it still processes it.

**Expected behavior**
Should give 400 Bad Request upon error.

**Desktop (please complete the following information):**
- OS: Ubuntu

**Additional context**
For the time being the only choice is to take by string and do validation manually.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.