drogonframework / drogonframework/drogon

Clang 16 warnings

Open
#1,656 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
14.3k
Forks
1.4k
Avg merge
1d 13h
Merged PRs (30d)
14

Description

Compiling Drogon using Clang 16 from MSYS2 produces a few warnings, repeated a bunch of times. I didn't pass any custom flags when building.

I suggest either fixing them, or at least silencing.
```none
/home/holyblackcat/Sandbox/1/drogon/lib/src/HttpResponseImpl.h:366:57: warning: unqualified call to 'std::move' [-Wunqualified-std-cast-call]
std::make_shared(move(gunzipBody));
^
std::
```
```none
/home/holyblackcat/Sandbox/1/drogon/lib/src/HttpAppFrameworkImpl.h:62:10: warning: 'addPlugins' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
void addPlugins(const Json::Value &configs);
^
/home/holyblackcat/Sandbox/1/drogon/lib/inc/drogon/HttpAppFramework.h:771:18: note: overridden virtual function is here
virtual void addPlugins(const Json::Value &configs) = 0;
^
In file included from /home/holyblackcat/Sandbox/1/drogon/lib/src/ConfigLoader.cc:16:
/home/holyblackcat/Sandbox/1/drogon/lib/src/HttpAppFrameworkImpl.h:63:10: warning: 'addPlugin' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
void addPlugin(const std::string &name,
^
/home/holyblackcat/Sandbox/1/drogon/lib/inc/drogon/HttpAppFramework.h:779:18: note: overridden virtual function is here
virtual void addPlugin(const std::string &name,
^
In file included from /home/holyblackcat/Sandbox/1/drogon/lib/src/HttpAppFrameworkImpl.cc:15:
/home/holyblackcat/Sandbox/1/drogon/lib/src/HttpAppFrameworkImpl.h:62:10: warning: 'addPlugins' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
void addPlugins(const Json::Value &configs);
^
/home/holyblackcat/Sandbox/1/drogon/lib/inc/drogon/HttpAppFramework.h:771:18: note: overridden virtual function is here
virtual void addPlugins(const Json::Value &configs) = 0;
^
In file included from /home/holyblackcat/Sandbox/1/drogon/lib/src/HttpAppFrameworkImpl.cc:15:
/home/holyblackcat/Sandbox/1/drogon/lib/src/HttpAppFrameworkImpl.h:63:10: warning: 'addPlugin' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
void addPlugin(const std::string &name,
^
/home/holyblackcat/Sandbox/1/drogon/lib/inc/drogon/HttpAppFramework.h:779:18: note: overridden virtual function is here
virtual void addPlugin(const std::string &name,
^
In file included from /home/holyblackcat/Sandbox/1/drogon/lib/src/HttpClientImpl.cc:16:
/home/holyblackcat/Sandbox/1/drogon/lib/src/HttpAppFrameworkImpl.h:62:10: warning: 'addPlugins' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
void addPlugins(const Json::Value &configs);
^
/home/holyblackcat/Sandbox/1/drogon/lib/inc/drogon/HttpAppFramework.h:771:18: note: overridden virtual function is here
virtual void addPlugins(const Json::Value &configs) = 0;
^
In file included from /home/holyblackcat/Sandbox/1/drogon/lib/src/HttpClientImpl.cc:16:
/home/holyblackcat/Sandbox/1/drogon/lib/src/HttpAppFrameworkImpl.h:63:10: warning: 'addPlugin' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
void addPlugin(const std::string &name,
^
/home/holyblackcat/Sandbox/1/drogon/lib/inc/drogon/HttpAppFramework.h:779:18: note: overridden virtual function is here
virtual void addPlugin(const std::string &name,
^
1 warning generated.
In file included from /home/holyblackcat/Sandbox/1/drogon/lib/src/FiltersFunction.cc:18:
/home/holyblackcat/Sandbox/1/drogon/lib/src/HttpAppFrameworkImpl.h:62:10: warning: 'addPlugins' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
void addPlugins(const Json::Value &configs);
^
/home/holyblackcat/Sandbox/1/drogon/lib/inc/drogon/HttpAppFramework.h:771:18: note: overridden virtual function is here
virtual void addPlugins(const Json::Value &configs) = 0;
^
In file included from /home/holyblackcat/Sandbox/1/drogon/lib/src/FiltersFunction.cc:18:
/home/holyblackcat/Sandbox/1/drogon/lib/src/HttpAppFrameworkImpl.h:63:10: warning: 'addPlugin' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
void addPlugin(const std::string &name,
^
/home/holyblackcat/Sandbox/1/drogon/lib/inc/drogon/HttpAppFramework.h:779:18: note: overridden virtual function is here
virtual void addPlugin(const std::string &name,
^
```
```none
/home/holyblackcat/Sandbox/1/drogon/orm_lib/inc/drogon/orm/Row.h:80:5: warning: explicitly defaulted default constructor is implicitly deleted [-Wdefaulted-function-deleted]
Row() noexcept = default;
^
/home/holyblackcat/Sandbox/1/drogon/orm_lib/inc/drogon/orm/Row.h:86:12: note: default constructor of 'Row' is implicitly deleted because field 'result_' has no default constructor
Result result_;
^
/home/holyblackcat/Sandbox/1/drogon/orm_lib/inc/drogon/orm/Row.h:80:22: note: replace 'default' with 'delete'
Row() noexcept = default;
^~~~~~~
delete
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.