drizzle-team / drizzle-team/drizzle-orm

Version numbers do not conform to the semver specification

Open
#5,386 0 comments 2 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
35.8k
Forks
1.6k
Avg merge
2d 7h
Merged PRs (30d)
4

Description

https://semver.org/#spec-item-10

> 10. Build metadata MAY be denoted by appending a plus sign and a series of dot separated identifiers immediately following the patch or pre-release version. Identifiers MUST comprise only ASCII alphanumerics and hyphens [0-9A-Za-z-]. Identifiers MUST NOT be empty. **Build metadata MUST be ignored when determining version precedence**. Thus two versions that differ only in the build metadata, have the same precedence. Examples: 1.0.0-alpha+001, 1.0.0+20130313144700, 1.0.0-beta+exp.sha.5114f85, 1.0.0+21AF26D3----117B344092BD.
>
> 11. Precedence refers to how versions are compared to each other when ordered.
>
> 1. Precedence MUST be calculated by separating the version into major, minor, patch and pre-release identifiers in that order (**Build metadata does not figure into precedence**).

`Semver` requires that a `plus sign` be used to separate `metadata`, not a `minus sign`.

```js
import semver from 'semver';

console.log(semver.gt('1.0.0-beta.13-ba3365d', '1.0.0-beta.9-e89174b')); // false ❌
console.log(semver.gt('1.0.0-beta.13+ba3365d', '1.0.0-beta.9+e89174b')); // true ✅
```

Related issue:
- https://github.com/denoland/deno/issues/29647#issuecomment-3913898974

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.