drizzle-team / drizzle-team/drizzle-orm

[DOCS]: Custom cache implementation does not compile, isTag parameter not there

Open
#4,905 1 comment 1 reaction 0 assignees View on GitHub
docs
Dominant language
TypeScript
Stars
35.8k
Forks
1.6k
Avg merge
2d 7h
Merged PRs (30d)
4

Description

### Enhancement hasn't been filed before.

- [x] I have verified this enhancement I'm about to request hasn't been suggested before.

### Describe the enhancement you want to request

First of all, it would be nice if some simple in-memory implementation was part of Drizzle, even AWS Lambda functions would benefit from those as they recycle lambdas. I think in-memory implementation would work for many cases.

But this problem is specifically about this part: https://orm.drizzle.team/docs/cache#custom-cache

Currently it has this signature for `put`:

```typescript
override async put(
key: string,
response: any,
tables: string[],
config?: CacheConfig,
): Promise {
// ...
}
```

However someone has added since a `isTag` function parameter, right signature is:

```typescript
override async put(
key: string,
response: any,
tables: string[],
isTag: boolean,
config?: CacheConfig,
): Promise {
// ...
}
```

Then it satisfies the Cache interface.

However how to use the new `isTag` property? I don't know how to update this implementation.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.