drizzle-team / drizzle-team/drizzle-orm-docs

Clarify that the ‘dynamic’ mode for query builders does not merge `where` calls

Open
#189 0 comments 10 reactions 0 assignees View on GitHub
Dominant language
MDX
Stars
241
Forks
401
Avg merge
5h 44m
Merged PRs (30d)
1

Description

Following the discussion given [here](https://discord.com/channels/1043890932593987624/1084576896039260202/threads/1181238415971328112), I'm creating this issue to make the "Dynamic query building" docs more clear.

The current issue is that for some reason the first time those docs are read, it's possible that people get the impression that using `$dynamic()` on a query enables the possibility to make multiple calls to `.where(...)` that are merged automatically by drizzle.

I know the docs don't state that drizzle merges the where calls and, if you read them after knowing the actual behavior, they are clear about the intent behind the `$dynamic()` function, but they can be improved to make more clear that `.where(...)` calls will keep the same behavior regarding overriding/merging.

Thanks!

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.