drivendataorg / drivendataorg/cloudpathlib

Failing CI steps on PRs from forks (azure install and live tests)

Open
#306 3 comments 0 reactions 0 assignees View on GitHub
github_actions tests
Dominant language
Python
Stars
628
Forks
88
Avg merge
17h 28m
Merged PRs (30d)
2

Description

We currently have a process where forks from PRs run two steps in our CI pipeline that require access to repo secrets to run properly. These show up on failing tests in the PR, which can be confusing.

For example, see this recent PR:
https://github.com/drivendataorg/cloudpathlib/actions/runs/3751066339

A few options:
- Don't run these tests on PRs from forks. Downside is that this means external contributions don't have live tests or azure install run against them.
- Skip these tests on PRs from forks, and only allow PRs from forks into a separate "staging" branch. Require that merges into `master` come from a local branch. Normal flow is that contributor PRs are pulled into staging if their tests pass and then into `master` if stating CI run comes back clean.
- Add a manual trigger for these steps, which we may be able to run on forks (not really sure if this is possible or not)
- Keep as is with failing tests that are a reminder to merge into a repo-local branch and create a PR that will run all the tests.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.