drivendataorg / drivendataorg/cloudpathlib
missing_ok kwarg for unlink diverges from pathlib defaults
- Dominant language
- Python
- Stars
- 628
- Forks
- 88
- Avg merge
- 17h 28m
- Merged PRs (30d)
- 2
Description
For the `unlink` function, `missing_ok=True` by default. The default in `pathlib` is `missing_ok=False`.
This has always been the behavior, but as of #230 it is made explicit.
If we want to follow `pathlib`, we'll need a deprecation cycle to warn folks.
Original context below.
-------------------
Yeah, I'm on the fence about this diverging from `pathlib` defaults. IMO this is the nicer default, but in general we use pathlib as a pretty strict guide. @jayqi any thoughts here?
I guess if we want to follow `pathlib` defaults here at some point we need to go through a deprecation warning cycle first.
_Originally posted by @pjbull in https://github.com/drivendataorg/cloudpathlib/pull/230#discussion_r884989307_
Contributor guide
Assessment
This issue has not been assessed yet.