drcmda / drcmda/react-contextual

cause memory leak when used in SSR

Open
#18 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
638
Forks
21
PR merge metrics
No merged PRs in 30d

Description

store.js
```
componentWillUnmount() {
if (this.props.id) removeNamedContext(this.props.id)
}
```
namedContext.js
```
componentWillUnmount() {
removeNamedContext(this.name)
}
```
context.js
```
const createContext = React.createContext
const providers = new Map()
const ProviderContext = createContext()

export function createNamedContext(name, initialState) {
const context = createContext(initialState)
providers.set(name, context)
return context
}

export function getNamedContext(name) {
return providers.get(name)
}

export function removeNamedContext(name) {
providers.delete(name)
}

```
componentWillUnmount will not execute on server side, which cause providers increase rapidly with request increase and cause memory leak.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.