dragonflydb / dragonflydb/dragonfly

`dragonfly/tiering_test.py::test_full_sync[df_factory0] ` failing during shutdown

Open
#6,191 1 comment 0 reactions 0 assignees View on GitHub
failing-test
Dominant language
C++
Stars
31.5k
Forks
1.3k
Avg merge
1d 10h
Merged PRs (30d)
137

Description

https://github.com/dragonflydb/dragonfly/actions/runs/20089095519/job/57632683127

does not seem related to closed issue https://github.com/dragonflydb/dragonfly/issues/5484

might not be related to test code, fails during teardown

```
dragonfly/instance.py:263: in stop
self.sed_proc.communicate()

...
E ValueError: I/O operation on closed file.

/usr/lib/python3.8/subprocess.py:1015: ValueError
```

Contributor guide

Open the contributing guide

Research direction

Start with the failing dragonfly/tiering_test.py::test_full_sync[df_factory0] run and the teardown traceback in dragonfly/instance.py:263, where stop() calls sed_proc.communicate(). Reproduce the shutdown failure from the linked Actions run, determine why the subprocess stream is already closed, and confirm the test completes without the ValueError.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.