dragonflydb / dragonflydb/dragonfly-operator

Fix Semantic Versioning for Helm Chart

Open
#494 3 comments 3 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
357
Forks
111
PR merge metrics
No merged PRs in 30d

Description

Can strict Semantic Versioning be used for the helm chart releases (use `1.5.0` instead of `v1.5.0`)?

In the `Chart.yaml` it says semantic versioning is required but the linked semver docs show the versions used for the dragonfly-operator are not valid.

https://github.com/dragonflydb/dragonfly-operator/blob/2192d38824f712d203d6a490cb625a5e12526fe5/charts/dragonfly-operator/Chart.yaml#L17-L18

> Is “v1.2.3” a semantic version?
No, “v1.2.3” is not a semantic version

https://semver.org/#is-v123-a-semantic-version

Below are some links with more details on this issue and how it breaks tools requiring Semantic Versioning.

[Helm Docs](https://helm.sh/docs/topics/charts/#charts-and-versioning)
[Helm Issue](https://github.com/helm/helm/issues/11107#issuecomment-1860317000)
[Dragonfly + Flux](https://github.com/dragonflydb/dragonfly-operator/issues/262)
[Kargo](https://github.com/akuity/kargo/issues/5604)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.