dragonflydb / dragonflydb/documentation

incorrect default cluster mode

Open
#350 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
8
Forks
31
Avg merge
3h 41m
Merged PRs (30d)
2

Description

Cluserting documentation says that the default for `--cluster_mode` is 'emulated' if not specified. However the implementation suggests this is not the case.

https://github.com/dragonflydb/dragonfly/blob/be11fa02cd0721aab2a3cbf7d23fb84f1f51d432/src/server/cluster_support.cc#L60-L69
```
if (cluster_mode_str == "emulated") {
cluster_mode = ClusterMode::kEmulatedCluster;
} else if (cluster_mode_str == "yes") {
cluster_mode = ClusterMode::kRealCluster;
} else if (cluster_mode_str.empty()) {
cluster_mode = ClusterMode::kNoCluster;
} else {
LOG(ERROR) << "Invalid value for flag --cluster_mode. Exiting...";
exit(1);
}
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.