dracula / dracula/spec

Shouldn't `Foreground` and `AnsiWhite` be different colors?

Open
#14 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
No language data
Stars
10
Forks
4
PR merge metrics
No merged PRs in 30d

Description

Hi !

I'm using Dracula in Windows Terminal, and I'm wondering if `Foreground` and `AnsiWhite` should maybe be different colors instead of the same one.

The reason I'm suggesting they should be different is because the default colors of the `TerminalFormatter` from the Pygments Python library for syntax highlighting uses `Foreground` to print "regular" tokens, and [`AnsiWhite` to print comments](https://github.com/pygments/pygments/blob/00072315fe40fe093fbbf1db5ebd67c46abf9bf7/pygments/formatters/terminal.py#L21-L27) (they call it `gray`). Since these two colors are the same with Dracula, it makes comments harder to distinguish from code (this is a screenshot from GDB, which uses Pygments for highlighting):

![image](https://user-images.githubusercontent.com/44212482/213944897-4da60bd1-1247-4637-a72c-ac1a8ba01c54.png)

Notice how the comment and the `printf` line use the same color. If I change `AnsiWhite` to be gray-ish instead, the comments are easily distinguishable:

![image](https://user-images.githubusercontent.com/44212482/213945146-0c4fd2f8-1779-4415-b40c-9bd6d9c72416.png)

What do you think ? :)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.