dpguthrie / dpguthrie/yahooquery

yahoo_login function does not work with newer version of Selenium

Open
#130 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
920
Forks
164
PR merge metrics
No merged PRs in 30d

Description

**Describe the bug**

The following 3 lines of code in 'yahoo_login' function in login.py gave an error when newer version of Selenium library is used. The suggested work around are also shown:

Original: self.driver.find_element_by_id("login-username").send_keys(self.username)
Change to: self.driver.find_element(By.ID,"login-username").send_keys(self.username)

Original: self.driver.find_element_by_xpath("//input[@id='login-signin']").click()
Change to: self.driver.find_element(By.XPATH,"//input[@id='login-signin']").click()

Original: self.driver.find_element_by_xpath("//button[@id='login-signin']").click()
Change to: self.driver.find_element(By.XPATH,"//button[@id='login-signin']").click()

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.