dozoisch / dozoisch/react-google-recaptcha

Published package contains more than it should?

Open
#293 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
1.1k
Forks
148
PR merge metrics
No merged PRs in 30d

Description

I've another PR to add data-action support that I've scope published pending the PR review. While working out how to publish an npm package I noted;

1. More than I think you intend is being included in the publish package? Look at the (beta)Code tab on the package page.
2. There's no index.d.ts.

On my repo you'll find a ScopedPackage branch that adds a GitHub action publish workflow that addresses each of the above.

Tbh I'm not certain if best practice is to include the type file or to prefer @types dev dependency, but for the scoped package the existing @types package doesn't work, so I had to include it, happy to remove; but take a look and if there's a PR you'd consider merging let me know?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.