doximity / doximity/simplekiq

Gracefully handle callback removal

Open
#7 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Ruby
Stars
98
Forks
8
PR merge metrics
No merged PRs in 30d

Description

BatchingJob auto-registers Sidekiq batch callbacks when you define an `on_x` method. The problem is that if you have a callback that you don't need anymore and update the code removing the method you'll get exceptions when the previously registered callbacks try to run. Since we're auto-registering it seems reasonable for us to also check that they are still there before trying to run them -- basically defining BatchingJob callbacks that no-op if the user's job hasn't implemented the callback methods. Some tricky async code change stuff to think through.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.