doximity / doximity/CallWithDoxDialer

[Suggestion] Properties vs Class variables

Open
#16 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Swift
Stars
6
Forks
1
PR merge metrics
No merged PRs in 30d

Description

```objc
@interface DoxDialerCaller() {
NSURL *_dialerSchemeURL;
NSURL *_openDialerInAppStoreURL;
UIImage *_dialerIcon;
UIImage *_dialerIconAsTemplate;
}
```

While I like class variables I believe the use o `_` before the name can be misleading because the "convention" is to name `properties` in this way.

Contributor guide

No contributing guide indexed for this repository

Research direction

Locate the DoxDialerCaller implementation containing the shown anonymous interface and inspect how these instance variables are referenced and distinguished from properties. Decide on a consistent naming convention, update the affected references if the project agrees, and verify that the project still builds.

Written by the indexing model from the issue text.

Assessment

Tech stack
objective-c
Domain
developer-experience
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.