downshift-js / downshift-js/downshift

previousSelectedItemsRef.current is not updated

Open
#1,535 3 comments 0 reactions 0 assignees View on GitHub
bug needs discussion
Dominant language
JavaScript
Stars
12.3k
Forks
936
PR merge metrics
No merged PRs in 30d

Description

https://github.com/downshift-js/downshift/blob/90d6d7208c61132c01868473c6dfac3a05e92076/src/hooks/useMultipleSelection/index.js#L81

in some special cases for multiple selection when we use `setSelectedItems` instead of addSelectedItem, it can happen that previousSelectedItemsRef.current is not updated because `setSelectedItems` sets the same amount of items but different.

#### Example
1, 2, 3, 4
set 2, 3
set 1, 4
but in previousSelectedItemsRef.current are still 2, 3
set 1, 2, 3
in previousSelectedItemsRef.current are 1,2,3 because length changed

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.